Re: ALSA: pcsp: Use common error handling code in snd_card_pcsp_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Takashi Iwai <tiwai@xxxxxxx>, alsa-devel@xxxxxxxxxxxxxxxx
Subject: Re: ALSA: pcsp: Use common error handling code in snd_card_pcsp_probe()
From: SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 22 Aug 2017 14:47:20 +0200
Cc: kernel-janitors@xxxxxxxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>, Dan Carpenter <dan.carpenter@xxxxxxxxxx>
In-reply-to: <s5hziar9483.wl-tiwai@suse.de>
References: <08ee0d6b-788b-2845-6964-e1e55c2d2292@users.sourceforge.net> <20170822121625.syvr64kwyh5xjexg@mwanda> <s5hziar9483.wl-tiwai@suse.de>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

> Also, please don't omit the negative value check.

Is it appropriate to treat non-zero values as error codes there generally?

Regards,
Markus
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Follow-Ups:
- Re: ALSA: pcsp: Use common error handling code in snd_card_pcsp_probe()
  - From: Takashi Iwai

References:
- [PATCH] ALSA: pcsp: Use common error handling code in snd_card_pcsp_probe()
  - From: SF Markus Elfring
- Re: [PATCH] ALSA: pcsp: Use common error handling code in snd_card_pcsp_probe()
  - From: Dan Carpenter
- Re: [PATCH] ALSA: pcsp: Use common error handling code in snd_card_pcsp_probe()
  - From: Takashi Iwai

Prev by Date: Applied "ASoC: rt5670: Fix GPIO headset detection regression" to the asoc tree
Next by Date: Re: ALSA: pcsp: Use common error handling code in snd_card_pcsp_probe()
Previous by thread: Re: [PATCH] ALSA: pcsp: Use common error handling code in snd_card_pcsp_probe()
Next by thread: Re: ALSA: pcsp: Use common error handling code in snd_card_pcsp_probe()
Index(es):
- Date
- Thread

[Index of Archives] [ALSA User] [Linux Audio Users] [Kernel Archive] [Asterisk PBX] [Photo Sharing] [Linux Sound] [Video 4 Linux] [Gimp] [Yosemite News]