On Tue, 22 Aug 2017 14:16:25 +0200, Dan Carpenter wrote: > > err = snd_card_register(card); > > - if (err < 0) { > > + if (err) { > > +free_card: > > snd_card_free(card); > > return err; > > } > > I thought we agreed, yesterday, to never use this style of error > handling? Yeah, this is definitely no-go. Also, please don't omit the negative value check. thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel