Re: [PATCH 3/8] drm/amd/amdgpu: Added a dwc quirk for Stoney platform

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 23, 2017 at 12:35:01PM -0400, Alex Deucher wrote:

> +	if (adev->asic_type == CHIP_STONEY) {
> +		i2s_pdata[1].quirks = DW_I2S_QUIRK_COMP_REG_OFFSET |
> +			DW_I2S_QUIRK_COMP_PARAM1 |
> +			DW_I2S_QUIRK_16BIT_IDX_OVERRIDE;
> +	} else {
> +		i2s_pdata[1].quirks = DW_I2S_QUIRK_COMP_REG_OFFSET |
> +			DW_I2S_QUIRK_COMP_PARAM1;
> +	}

Quirks like this are better written as switch statements since that
makes it easier to handle further variants in future.

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux