> -----Original Message----- > From: Vinod Koul [mailto:vinod.koul@xxxxxxxxx] > Sent: Wednesday, April 26, 2017 1:38 PM > To: weiyongjun (A) <weiyongjun1@xxxxxxxxxx> > Cc: Wei Yongjun <weiyj.lk@xxxxxxxxx>; Liam Girdwood > <lgirdwood@xxxxxxxxx>; Mark Brown <broonie@xxxxxxxxxx>; Jaroslav > Kysela <perex@xxxxxxxx>; Takashi Iwai <tiwai@xxxxxxxx>; Pardha Saradhi K > <pardha.saradhi.kesapragada@xxxxxxxxx>; G Kranthi > <gudishax.kranthikumar@xxxxxxxxx>; Hardik T Shah > <hardik.t.shah@xxxxxxxxx>; Jeeja KP <jeeja.kp@xxxxxxxxx>; alsa- > devel@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH -next] ASoC: Intel: Skylake: Fix to use > list_for_each_safe() when delete items > > On Tue, Apr 25, 2017 at 07:57:57AM +0000, weiyongjun (A) wrote: > > > > > > > > Since we will remove items off the list using list_del() we need > > > > to use a safe version of the list_for_each() macro aptly named > > > > list_for_each_safe(). > > > > > > ah yes, god catch > > > > > > > This is detected by Coccinelle semantic patch. > > > > > > It is a good practice to include the script you used, do you mind adding > > > that in the log? > > > > > > > Sure. > > Sorry I meant this should be in changelog of the patch :) OK, I will add this and send the v2 version patch later. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel