> -----Original Message----- > From: Vinod Koul [mailto:vinod.koul@xxxxxxxxx] > Sent: Tuesday, April 25, 2017 12:01 PM > To: Wei Yongjun <weiyj.lk@xxxxxxxxx> > Cc: Liam Girdwood <lgirdwood@xxxxxxxxx>; Mark Brown > <broonie@xxxxxxxxxx>; Jaroslav Kysela <perex@xxxxxxxx>; Takashi Iwai > <tiwai@xxxxxxxx>; Pardha Saradhi K > <pardha.saradhi.kesapragada@xxxxxxxxx>; G Kranthi > <gudishax.kranthikumar@xxxxxxxxx>; Hardik T Shah > <hardik.t.shah@xxxxxxxxx>; Jeeja KP <jeeja.kp@xxxxxxxxx>; weiyongjun (A) > <weiyongjun1@xxxxxxxxxx>; alsa-devel@xxxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH -next] ASoC: Intel: Skylake: Fix to use > list_for_each_safe() when delete items > > On Tue, Apr 25, 2017 at 03:28:17AM +0000, Wei Yongjun wrote: > > From: Wei Yongjun <weiyongjun1@xxxxxxxxxx> > > > > Since we will remove items off the list using list_del() we need > > to use a safe version of the list_for_each() macro aptly named > > list_for_each_safe(). > > ah yes, god catch > > > This is detected by Coccinelle semantic patch. > > It is a good practice to include the script you used, do you mind adding > that in the log? > Sure. @@ iterator name list_for_each; expression E; expression pos, head; identifier l; @@ * list_for_each(pos, head) { ... * \(list_del\|list_del_init\|list_move\|list_move_tail\)(pos, ...); ... when != \(goto l; \| break; \| return E; \| return;\) } @@ expression E; expression pos, head, ep; identifier list; identifier l; @@ * list_for_each(pos, head) { ... * ep = list_entry(pos, ..., list); ... * \(list_del\|list_del_init\|list_move\|list_move_tail\)(&ep->list, ...); ... when != \(goto l; \| break; \| return E; \| return;\) } @@ iterator name list_for_each_prev; expression E; expression pos, head; identifier l; @@ * list_for_each_prev(pos, head) { ... * \(list_del\|list_del_init\)(pos); ... when != \(goto l; \| break; \| return E; \| return;\) } @@ iterator name list_for_each_entry; expression E; expression pos, head; identifier l, member; @@ * list_for_each_entry(pos, head, member) { ... * \(list_del\|list_del_init\)(&pos->member); ... when != \(goto l; \| break; \| return E; \| return;\) } @@ iterator name list_for_each_entry_from; expression E; expression pos, head; identifier l, member; @@ * list_for_each_entry_from(pos, head, member) { ... * \(list_del\|list_del_init\)(&pos->member); ... when != \(goto l; \| break; \| return E; \| return;\) } @@ iterator name list_for_each_entry_reverse; expression E; expression pos, head; identifier l, member; @@ * list_for_each_entry_reverse(pos, head, member) { ... * \(list_del\|list_del_init\)(&pos->member); ... when != \(goto l; \| break; \| return E; \| return;\) } _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
