On Mon, Apr 3, 2017 at 9:30 AM, Rob Herring <robh@xxxxxxxxxx> wrote: > On Fri, Mar 31, 2017 at 10:16:34AM +0900, Ryan Lee wrote: >> Signed-off-by: Ryan Lee <ryans.lee@xxxxxxxxxxxxxxxxxxx> >> --- >> >> Changes since v4: >> * Removed support for SND_SOC_DAIFMT_CBS_CFM. >> * Fixed coding style for indention. >> * Removed variables if it has only one user. >> * Assigned ch_size directly. >> * Removed oring. >> * Put the return false in the switch statement. >> * Removed 'Monomix Output' and 'Speaker Source' controls. >> * Modified control names per control-names.rst. >> * Moved Revision ID check code to i2c_probe function. >> * Added 'Current Limit' control. >> * Removed 'devm__kfree' function. >> >> Changes since v3: >> * Combined MAX98926 and MAX98927 binding. Kept existing property name. > > This looks fine, but: > >> Changes since v2: >> * Removed local register read/write function to avoid duplication of ASoC core function. >> >> .../devicetree/bindings/sound/max98925.txt | 22 - >> .../devicetree/bindings/sound/max98926.txt | 32 - >> .../devicetree/bindings/sound/max9892x.txt | 41 + >> sound/soc/codecs/Kconfig | 5 + >> sound/soc/codecs/Makefile | 2 + >> sound/soc/codecs/max98927.c | 841 +++++++++++++++++++++ >> sound/soc/codecs/max98927.h | 272 +++++++ >> 7 files changed, 1161 insertions(+), 54 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/sound/max98925.txt >> delete mode 100644 Documentation/devicetree/bindings/sound/max98926.txt >> create mode 100755 Documentation/devicetree/bindings/sound/max9892x.txt >> mode change 100644 => 100755 sound/soc/codecs/Kconfig >> mode change 100644 => 100755 sound/soc/codecs/Makefile >> create mode 100755 sound/soc/codecs/max98927.c >> create mode 100755 sound/soc/codecs/max98927.h > > These should all be 644 mode. I've changed the mode to 644. Thank you. > > Rob _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
