Hi Simon > > > > /* > > > > + * It will set SSIWSR.CONT here, but SSICR.CKDV = 000 > > > > + * with it is not allowed. (SSIWSR.WS_MODE with > > > > + * SSICR.CKDV = 000 is not allowed either). > > > > + * Skip it. See SSICR.CKDV > > > > + */ > > > > + if (j == 0) > > > > + continue; > > > > > > Why not change the *for* statement itself to start with j = 1? > > > > It can be one solution. Actually my local 1st patch was such style. > > But I thought that it is difficult to notice such magical operation from code. > > Thus, I used this style > > FWIIW, I think if you have a comment, like the one above, then j = 1 should > be obvious enough. I'm OK for both, and have no special opinion about this. Let's follow to ALSA SoC maintainer's opinion Best regards --- Kuninori Morimoto _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel