On Tue, 21 Mar 2017 06:28:07 +0100, Ian W MORRISON wrote: > > Create a specific menu for the CONFIG_HDMI_LPE_AUDIO setting. > Add additional narrative to further explain the function of the > CONFIG_HDMI_LPE_AUDIO setting. > Remove subsequently unnecessary CONFIG_SND_X86 setting. > > Signed-off-by: Ian W Morrison <linuxium@xxxxxxxxxxxxxxx> > --- > sound/x86/Kconfig | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/sound/x86/Kconfig b/sound/x86/Kconfig > index 84c8f8fc..a89d769 100644 > --- a/sound/x86/Kconfig > +++ b/sound/x86/Kconfig > @@ -1,10 +1,5 @@ > -menuconfig SND_X86 > - tristate "X86 sound devices" > - depends on X86 > - ---help--- > - X86 sound devices that don't fall under SoC or PCI categories > - > -if SND_X86 > +menu "HDMI LPE for SoC audio support" > + comment "Required for HDMI audio support on Intel Baytrail and > Cherrytrail" No... This is doubly wrong. First off, the section isn't only about LPE audio, but it filters about x86-specific sound devices. Second, by your change, it misses the dependency on X86. I wonder whether the tristate of CONFIG_SND_X86 makes something bad for Canonical's build. Try to change to bool like below. Does it improve the situation? Takashi -- 8< -- diff --git a/sound/x86/Kconfig b/sound/x86/Kconfig index 84c8f8fc597c..707a8bd1725d 100644 --- a/sound/x86/Kconfig +++ b/sound/x86/Kconfig @@ -1,5 +1,5 @@ menuconfig SND_X86 - tristate "X86 sound devices" + bool "X86 sound devices" depends on X86 ---help--- X86 sound devices that don't fall under SoC or PCI categories _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
