On Wed, 2017-01-04 at 15:03 +0800, Mengdong Lin wrote: > > On 01/04/2017 04:09 AM, Pierre-Louis Bossart wrote: > > > >>>> I dont think we need vendor (it just makes it too long). The product > >>>> or board > >>>> name should be unique enough for us to load the correct files. > >>>> > >>>> Liam > >>> Yes, from the sample machines I checked, product or board name are > >>> unique. But I feel there might be the risk that two vendors happen to > >>> use the same product or board name, e.g. "T100TA". > >> I think this would be problematic from a legal/marketing position from > >> two different vendors so it would be unlikely. > > > > Please don't remove the manufacturer name for now... > > Some vendors use product names that are indeed unique and easy enough to > > remember, but others like Lenovo use "1952W5R" or "20C3001VHH" (real > > examples you can Google to see I am not making this up). The board name > > can also be "SKG18 t". I really have no appetite for a UCM directory > > called 20C3001VHH.SKG18t :-) > > I would also be ready to bet that smaller manufacturers in the Chinese > > ecosystem use similar product names at the DMI level. removing the > > vendor name would likely result in mistakes. > > You really want the manufacturer name to make the maintenance of these > > files easier on the rest of us. Sometimes the DMI version field is > > actually more self-explanatory, e.g. "ThinkPad 60" or "ThinkPad 10" for > > the two Lenovo examples, maybe this is something we ought to look at. > > > > > > So we'll keep the manufacturer name. > > And let's put the "Product version" as well if available, Liam? Yes, lets keep the manufacturer name. I agree with Pierre in that we dont want meaningless directories names. Creating a directory structures like 1) manufacturer/product/board OR 2) manufacturer/product OR 3) manufacturer/board (2 or 3 if board or product is NULL) are fine by me and make finding the correct card simpler. You could even replace the . with / in your longname to save the string conversion later on. Liam > > I also observed Lenovo puts the the user-friendly name in the product > version like "Thinkpad S5 Yoga 15", while it product name is > "20DQA00KCD", no self-explanatory. > > It seems different manufacturer tend to put self-explanatory name in > different fields: > Lenovo thinkpad: product version > Dell: product name > ASUS: both product name and board name > Intel: board name > > Do we want some table to specify the field we want for major vendors? So > we may just pick the most valuable DMI field for the card long name, for > those manufacturers to save the space. But it may not scale if the > manufacturer change their preference or use different way for different > product series, since I only checked a few machines by a few vendors. > > Also I wonder if we find the key word like "Dell, HP or ASUS", may we > not use verbatim copy on the vendor name but just use these key words? > This can also save some space. > > Thanks > Mengdong > > > > > > > _______________________________________________ > > Alsa-devel mailing list > > Alsa-devel@xxxxxxxxxxxxxxxx > > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel > > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@xxxxxxxxxxxxxxxx > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
