Re: [PATCH v2 1/2] ASoC: core: Add API to use DMI name in sound card long name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




I dont think we need vendor (it just makes it too long). The product or board
name should be unique enough for us to load the correct files.

Liam
Yes, from the sample machines I checked, product or board name are
unique. But I feel there might be the risk that two vendors happen to
use the same product or board name, e.g. "T100TA".
I think this would be problematic from a legal/marketing position from
two different vendors so it would be unlikely.

Please don't remove the manufacturer name for now...
Some vendors use product names that are indeed unique and easy enough to remember, but others like Lenovo use "1952W5R" or "20C3001VHH" (real examples you can Google to see I am not making this up). The board name can also be "SKG18 t". I really have no appetite for a UCM directory called 20C3001VHH.SKG18t :-) I would also be ready to bet that smaller manufacturers in the Chinese ecosystem use similar product names at the DMI level. removing the vendor name would likely result in mistakes. You really want the manufacturer name to make the maintenance of these files easier on the rest of us. Sometimes the DMI version field is actually more self-explanatory, e.g. "ThinkPad 60" or "ThinkPad 10" for the two Lenovo examples, maybe this is something we ought to look at.


_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux