On Fri, Nov 18, 2016 at 09:48:10AM +0000, Charles Keepax wrote:
> > > +
> > > + switch (cmd) {
> > > + case SNDRV_PCM_TRIGGER_START:
> > > + ret = snd_soc_dai_set_sysclk(codec_dai, NAU8825_CLK_FLL_FS, 0,
> > > + SND_SOC_CLOCK_IN);
> > > + if (ret < 0)
> > > + dev_err(codec_dai->dev, "can't set FS clock %d\n", ret);
> > > + ret = snd_soc_dai_set_pll(codec_dai, 0, 0, runtime->rate,
> > > + runtime->rate * 256);
> > > + if (ret < 0)
> > > + dev_err(codec_dai->dev, "can't set FLL: %d\n", ret);
> > > + break;
> >
> > starting clock on trigger doesnt sound right to me..
> >
>
> Me neither can't trigger be called from an atomic context? In
> which case I would expect operations on an external CODEC to be
> very likely to cause issues.
Not in this case :) We use non atomic triggers.. But that doesnt make this
correct :)
--
~Vinod
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
