On 08/30, Pierre-Louis Bossart wrote: > On 8/30/16 7:37 PM, Stephen Boyd wrote: > >On 08/17, Pierre-Louis Bossart wrote: > >>@@ -414,6 +456,13 @@ static int pmc_setup_dev(struct pci_dev *pdev, const struct pci_device_id *ent) > >> if (ret) > >> dev_warn(&pdev->dev, "debugfs register failed\n"); > >> > >>+ /* Register platform clocks - PMC_PLT_CLK [5:0] */ > >>+ clkdev = platform_device_register_data(NULL, "clk-byt-plt", -1, > >>+ &clks, sizeof(clks)); > > > >Shouldn't we register the clk device as a child of the > >registering device? Otherwise it's just floating in the device > >hierarchy? > > from a hardware perspective these clocks are pretty much stand-alone > and independent, there is no real parent/child dependency I can > think of and having this as 'floating' isn't very far from reality. Hmm... what about things like suspend/resume? Presumably we would want the clk device that's touching the pmc register space to be suspended before we suspend pmc itself? Not having a parent would mean it's a virtual device which doesn't seem correct. It's a logical device that is related to the pmc device. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
