On Tue, 2016-06-07 at 17:15 +0100, Mark Brown wrote: > On Fri, Jun 03, 2016 at 12:56:20PM +0800, Garlic Tseng wrote: > > > +void mt2701_init_clock(struct mtk_base_afe *afe) > > +{ > > + struct mt2701_afe_private *afe_priv = afe->platform_priv; > > + int i = 0; > > + > > + for (i = 0; i < MT2701_CLOCK_NUM; i++) { > > + afe_priv->clocks[i] = devm_clk_get(afe->dev, aud_clks[i]); > > + if (IS_ERR(aud_clks[i])) > > + dev_warn(afe->dev, "%s devm_clk_get %s fail\n", > > + __func__, aud_clks[i]); > > + } > > +} > > This looks like we just ignore the error but I'm not seeing anything > that stops us trying to use the clocks or handle deferred probe? The probe for platform_driver should fail if the clock error occur. I'll fix it. Thanks. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel