On Fri, May 13, 2016 at 03:50:28PM -0500, Paul.Handrigan@xxxxxxxxxx wrote:
> +static struct regmap *cs35l33_get_regmap(struct device *dev)
> +{
> + struct cs35l33_private *cs35l33 = dev_get_drvdata(dev);
> +
> + return cs35l33->regmap;
> +}
Doesn't the default work for you?
> + for (i = 0; i < CS35L33_INT_ATTEMPTS; i++) {
> + /* ack the irq by reading both status registers */
Why do we need this...?
> + if (sticky_val1 & CS35L33_AMP_SHORT) {
> + dev_err(codec->dev, "Amp short error\n");
> + if (!(current_val & CS35L33_AMP_SHORT)) {
dev_crit()
> + if (sticky_val1 & CS35L33_OTE) {
> + dev_err(codec->dev, "Over temperature error\n");
Same here - these are extremely serious and probably indicate very
serious physical problems.
> + } else if (IS_ERR(cs35l33->reset_gpio)) {
> + dev_err(&i2c_client->dev, "%s ERROR: Can't get reset GPIO\n",
> + __func__);
> + return PTR_ERR(cs35l33->reset_gpio);
Indentation is messed up here.
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
