On Mon, May 09, 2016 at 02:13:55PM +0200, Takashi Iwai wrote: > On Wed, 04 May 2016 15:59:06 +0200, > Charles Keepax wrote: > > > > We return negative values from the file_operations poll callback > > in a few places, this callback returns an unsigned int and is > > expected to only return the poll specific flags. This series > > fixes up these issues and makes a couple of small tidy ups to the > > code around the edges of those functions. > > > > I noticed this issue whilst doing some additional testing on my > > propagation of compressed stream error series, but I decided to > > push these up separately as it is worth getting the fixes in > > now and not tying them up with that patch chain which is taking > > longer to get merged. Also I included the first patch of that > > chain (Replace complex if statement with switch) because it is a > > trivial tidy up and might as well get merged now as well. > > Patches 2, 3 and 4 miss Vinod's ack. Vinod, are you OK with them? Yup, they look good to me so: Acked-by: Vinod Koul <vinod.koul@xxxxxxxxx> Thanks -- ~Vinod _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel