Re: [PATCH 0/5] Fix poll error returns

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 04 May 2016 15:59:06 +0200,
Charles Keepax wrote:
> 
> We return negative values from the file_operations poll callback
> in a few places, this callback returns an unsigned int and is
> expected to only return the poll specific flags. This series
> fixes up these issues and makes a couple of small tidy ups to the
> code around the edges of those functions.
> 
> I noticed this issue whilst doing some additional testing on my
> propagation of compressed stream error series, but I decided to
> push these up separately as it is worth getting the fixes in
> now and not tying them up with that patch chain which is taking
> longer to get merged.  Also I included the first patch of that
> chain (Replace complex if statement with switch) because it is a
> trivial tidy up and might as well get merged now as well.

Patches 2, 3 and 4 miss Vinod's ack.  Vinod, are you OK with them?


thanks,

Takashi

> 
> Thanks,
> Charles
> 
> Charles Keepax (5):
>   ALSA: pcm: Fix poll error return codes
>   ALSA: compress: Use snd_compr_get_poll on error path
>   ALSA: compress: Remove pointless NULL check
>   ALSA: compress: Fix poll error return codes
>   ALSA: compress: Replace complex if statement with switch
> 
>  sound/core/compress_offload.c | 25 ++++++++++++-------------
>  sound/core/pcm_native.c       |  4 ++--
>  2 files changed, 14 insertions(+), 15 deletions(-)
> 
> -- 
> 2.1.4
> 
> 
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux