On Sat, Jan 30, 2016 at 07:13:35PM +0530, Subhransu S. Prusty wrote:
> + if (!pin->eld.monitor_present || !pin->eld.eld_valid) {
> +
> + dev_info(&edev->hdac.dev, "%s: disconnect for pin %d\n",
> + __func__, pin->nid);
> + goto put_hdac_device;
Will this get noisy?
> + /* TODO: use i915 component for reading ELD later */
> + if (hdac_hdmi_get_eld(&edev->hdac, pin->nid,
> + pin->eld.eld_buffer,
> + &pin->eld.eld_size) == 0) {
> +
> + print_hex_dump_bytes("Eld: ", DUMP_PREFIX_OFFSET,
> + pin->eld.eld_buffer, pin->eld.eld_size);
ELD is an acronym, please write it properly (there's some other examples
in the patch).
> + } else {
> + dev_err(&edev->hdac.dev, "ELD invalid\n");
> + pin->eld.monitor_present = false;
> + pin->eld.eld_valid = false;
> + }
Is it really invalid or did we fail to read it? There's a difference as
far as debugging is concerned (one means there's an I/O problem, the
other means that the display is reporting nonsense). Perhaps this
should be silent and let the read function be more specific?
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
