On Sun, 22 Nov 2015, Pavel Machek wrote: > On Mon 2015-11-16 14:11:42, Charles Keepax wrote: > > On Sat, Nov 14, 2015 at 10:16:33PM +0100, Pavel Machek wrote: > > > HiOn Sat 2015-11-14 18:49:40, Mark Brown wrote: > > > > On Sat, Nov 14, 2015 at 06:59:16PM +0100, Pavel Machek wrote: > > > > > > > > > Well, mfd_core.c seems to call regulator_bulk_register_supply_alias() > > > > > with device that does not have dev_name initialized. > > > > > > > > OK, that'll be the problem then - we're not mapping the supply into the > > > > individual child device but rather system wide, probably because that > > > > mapping is being done too early, before we've actually created the > > > > device. > > > > > > Take a look at mfd_add_device(). Yes, we do > > > regulator_bulk_register_supply_alias() before doing > > > platform_device_add(). > > > > > > > > regulator_bulk_register_supply_alias() results in "Adding alias" > > > > > stuff, and then drivers/regulator/arizona-micsupp.c tries to register > > > > > another "MICVDD". > > > > > > > > That's fine because all supplies should be namespaced with a device. > > > > The goal is to say "Supply X on device Y" (we do support exceptions for > > > > the few cases where there are not yet any devices involved but this > > > > clearly isn't one of them). > > > > Indeed that should be the case. > > > > > > > > Well, clearly someone should tell that to wm5102 > > > maintainers. Hmm. It looks like driver is marked supported but there > > > are no names attached? > > > > > > WOLFSON MICROELECTRONICS DRIVERS > > > L: patches@xxxxxxxxxxxxxxxxxxxxxxxxxxx > > > T: git git://opensource.wolfsonmicro.com/linux-2.6-asoc > > > T: git git://opensource.wolfsonmicro.com/linux-2.6-audioplus > > > W: > > > http://opensource.wolfsonmicro.com/content/linux-drivers-wolfson-device\ > > > s > > > S: Supported > > > > > > I guess Charles Keepax should be listed there? > > > > The patches mailing list functions as maintainer here. That way > > anyone who works on upstream Linux stuff here will see the email > > so you have more chance of someone replying. Also convient for > > when people leave the company etc. makes for an easy transition. > > I am afraid though that as in this case you are not always going > > to get a reply over the weekend. > > Well.. maintainer is a responsible person. Yes, you can list a mailing > list in maintainers file.. but mailing list is not going to be > responsible for that. > > Having a real name of person helps; if your name was listed there, I'd > know you (are supposed to be) authoritative person for this. > > I see it will need to be updated from time to time, but having name > really helps. A Mailing List is perfectly adequate for drivers which reside in a maintained subsystem. No requirement to submit names, particularly if there are lots of authorities personnel or if the personalities change regularly. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
