Re: [PATCH 1/3] ASoC: dapm: Add kcontrol support for PGAs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 20, 2015 at 05:58:46PM +0200, Lars-Peter Clausen wrote:
> > -static int dapm_create_or_share_mixmux_kcontrol(struct snd_soc_dapm_widget *w,
> > -	int kci)
> > +static int dapm_create_or_share_mixmuxpga_kcontrol(
> 
> ... but maybe just call it dapm_create_or_share_kcontrol()

I don't mind that

> 
> > +		struct snd_soc_dapm_widget *w, int kci)
> >  {
> >  	struct snd_soc_dapm_context *dapm = w->dapm;
> >  	struct snd_card *card = dapm->card->snd_card;
> > @@ -822,6 +822,10 @@ static int dapm_create_or_share_mixmux_kcontrol(struct snd_soc_dapm_widget *w,
> >  				wname_in_long_name = true;
> >  				kcname_in_long_name = false;
> >  				break;
> > +			case snd_soc_dapm_pga:
> 
> This should have the same behavior as mixers and switches, just add the case
> there instead having a different path.

Oh yes thanks for pointing out that makese better sense, will update in v2.

-- 
~Vinod
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux