On 10/20/2015 05:38 PM, Vinod Koul wrote:
> From: Jeeja KP <jeeja.kp@xxxxxxxxx>
>
> For DSPs we can define processing blocks as DAPM PGA widgets.
> Some of these proceesing blocks can be configured by usermode
> like EQ etc. So we need to add support of kcontrol for PGA
> widgets.
>
> Signed-off-by: Jeeja KP <jeeja.kp@xxxxxxxxx>
> Signed-off-by: Mythri P K <mythri.p.k@xxxxxxxxx>
> Signed-off-by: Vinod Koul <vinod.koul@xxxxxxxxx>
This looks ok ...
> ---
> sound/soc/soc-dapm.c | 22 +++++++++++++++-------
> 1 file changed, 15 insertions(+), 7 deletions(-)
>
> diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
> index ff8bda471b25..746800380eb7 100644
> --- a/sound/soc/soc-dapm.c
> +++ b/sound/soc/soc-dapm.c
> @@ -779,8 +779,8 @@ static int dapm_is_shared_kcontrol(struct snd_soc_dapm_context *dapm,
> * Determine if a kcontrol is shared. If it is, look it up. If it isn't,
> * create it. Either way, add the widget into the control's widget list
> */
> -static int dapm_create_or_share_mixmux_kcontrol(struct snd_soc_dapm_widget *w,
> - int kci)
> +static int dapm_create_or_share_mixmuxpga_kcontrol(
... but maybe just call it dapm_create_or_share_kcontrol()
> + struct snd_soc_dapm_widget *w, int kci)
> {
> struct snd_soc_dapm_context *dapm = w->dapm;
> struct snd_card *card = dapm->card->snd_card;
> @@ -822,6 +822,10 @@ static int dapm_create_or_share_mixmux_kcontrol(struct snd_soc_dapm_widget *w,
> wname_in_long_name = true;
> kcname_in_long_name = false;
> break;
> + case snd_soc_dapm_pga:
This should have the same behavior as mixers and switches, just add the case
there instead having a different path.
> + wname_in_long_name = true;
> + kcname_in_long_name = true;
> + break;
> default:
> return -EINVAL;
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
