On Mon, 1 Nov 2010, pl bossart wrote:
Thanks Jaroslav for this quick review.
Use one 'if' and a goto behind the last condition to simplify things.
will do
struct snd_interval {
   Âunsigned int min, max;
The PCM protocol version should be increased.
Humm, this one I don't understand. I didn't change anything, just used
a bit in an existing flag? What are you specifically referring to?
Increase subminor in SNDRV_PCM_VERSION . It allows alsa-lib to check if
the feature is implemented in the driver (although I admit that this
change does not require special checks against the protocol version, but
it's standard procedure to change the subminor when the API is extended).
@@ -297,6 +297,7 @@ struct snd_pcm_runtime {
   Âunsigned int info;
   Âunsigned int rate_num;
   Âunsigned int rate_den;
+ Â Â Â Âbool no_period_irq;
I would use an unsigned int bit field rather than bool in this case to make
addition in-line with other structures in this file.
will do.
Thanks.
Jaroslav
-----
Jaroslav Kysela <perex@xxxxxxxx>
Linux Kernel Sound Maintainer
ALSA Project, Red Hat, Inc.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
