Thanks Jaroslav for this quick review.
> Use one 'if' and a goto behind the last condition to simplify things.
will do
>> struct snd_interval {
>> unsigned int min, max;
>
> The PCM protocol version should be increased.
Humm, this one I don't understand. I didn't change anything, just used
a bit in an existing flag? What are you specifically referring to?
>> @@ -297,6 +297,7 @@ struct snd_pcm_runtime {
>> unsigned int info;
>> unsigned int rate_num;
>> unsigned int rate_den;
>> + bool no_period_irq;
>
> I would use an unsigned int bit field rather than bool in this case to make
> addition in-line with other structures in this file.
will do.
-Pierre
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
