On Tue, 2010-06-08 at 22:49 +0800, Wan ZongShun wrote: > 2010/6/8 Eric Miao <eric.y.miao@xxxxxxxxx>: > > 2010/6/8 Wan ZongShun <mcuos.com@xxxxxxxxx>: > >> In order to allow the sharing of the pxa2xx-ac97 driver file with pxa168, > >> we have to do a little change to pxa2xx-ac97 file. > >> > >> All private register addresses were located in mach/include/ac97.h. > > > > This is not the right way to go, as suggested already. I hope the ac97 > > driver is more self-contained. i.e. having a platform device for: > > > > - where the registers are mapped from > > - drcmr channel numbers can be encoded within dma resource > > - ac97 register definitions are not exposed everywhere > > > > Got it, so I should put above to platform_device and remove regs-ac97.h, > any private bit definition should be removed to driver directory as > driver _only_. > ...and could you also CC Mark on any ASoC related changes too. Thanks Liam -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
