2010/6/8 Eric Miao <eric.y.miao@xxxxxxxxx>: > 2010/6/8 Wan ZongShun <mcuos.com@xxxxxxxxx>: >> In order to allow the sharing of the pxa2xx-ac97 driver file with pxa168, >> we have to do a little change to pxa2xx-ac97 file. >> >> All private register addresses were located in mach/include/ac97.h. > > This is not the right way to go, as suggested already. I hope the ac97 > driver is more self-contained. i.e. having a platform device for: > > - where the registers are mapped from > - drcmr channel numbers can be encoded within dma resource > - ac97 register definitions are not exposed everywhere > Got it, so I should put above to platform_device and remove regs-ac97.h, any private bit definition should be removed to driver directory as driver _only_. -- *linux-arm-kernel mailing list mail addr:linux-arm-kernel@xxxxxxxxxxxxxxxxxxx you can subscribe by: http://lists.infradead.org/mailman/listinfo/linux-arm-kernel * linux-arm-NUC900 mailing list mail addr:NUC900@xxxxxxxxxxxxxxxx main web: https://groups.google.com/group/NUC900 you can subscribe it by sending me mail: mcuos.com@xxxxxxxxx _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
