On Wed, Jun 02, 2010 at 10:43:07AM +0100, Liam Girdwood wrote: > On Wed, 2010-06-02 at 13:54 +0800, Wan ZongShun wrote: > > This patch is to remove the 'SUBSTREAM_TYPE','PCM_TX' and 'PCM_RX' definition. > > > > There is no need to redefine SNDRV_PCM_STREAM_PLAYBACK as PCM_TX, > > the SUBSTREAM_TYPE(substream) can be deleted too, the playback or record can be > > judged by 'if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)' directly rather > > than 'if (PCM_TX == stype)', which makes the codes easy to read. > > > > Signed-off-by: Wan ZongShun<mcuos.com@xxxxxxxxx> Note here that you're still missing a space betwen your name and e-mail address. > All > Acked-by: Liam Girdwood <lrg@xxxxxxxxxxxxxxx> I've applied all the patches, since I had to fix up the changelogs anyway I updated the ms to us in the changelog for patch 2. Thanks. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
