Re: [PATCH v2 1/3]AsoC/nuc900: patch for SUBSTREAM_TYPE', 'PCM_TX' and 'PCM_RX' removal

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2010-06-02 at 13:54 +0800, Wan ZongShun wrote:
> This patch is to remove the 'SUBSTREAM_TYPE','PCM_TX' and 'PCM_RX' definition.
> 
> There is no need to redefine SNDRV_PCM_STREAM_PLAYBACK as PCM_TX,
> the SUBSTREAM_TYPE(substream) can be deleted too, the playback or record can be
> judged by 'if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)' directly rather
> than 'if (PCM_TX == stype)', which makes the codes easy to read.
> 
> Signed-off-by: Wan ZongShun<mcuos.com@xxxxxxxxx>

All 

Acked-by: Liam Girdwood <lrg@xxxxxxxxxxxxxxx>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel


[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux