On Wed, Aug 19, 2009 at 11:44 PM, Mark Brown<broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > On Wed, Aug 19, 2009 at 10:59:56PM +0900, Magnus Damm wrote: > >> > +struct fsi_master *master; > >> Is it really necessary to have "master" as a global variable? Maybe >> this global variable is there to work around some framework issue? > > There's no ASoC reason for doing this. Anything that needs to be shared > between different DAIs can always be shared via the DMA driver. I sometimes see i2c workarounds so i was wondering if this was a similar issue. Good to hear that the ASoC framework is clean. > Looking at the driver I rather suspect it only supports one FSI at once > and the capture support is also incomplete. I don't see much problem > merging the driver with these limitations, it's generally been much > easier to get people to fix problems with merged drivers than to get > people to contribute entirely new drivers. Doing it incrementally sounds very good. Thank you! / magnus _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
