On Wed, Aug 19, 2009 at 10:59:56PM +0900, Magnus Damm wrote: > > +struct fsi_master *master; > Is it really necessary to have "master" as a global variable? Maybe > this global variable is there to work around some framework issue? There's no ASoC reason for doing this. Anything that needs to be shared between different DAIs can always be shared via the DMA driver. Looking at the driver I rather suspect it only supports one FSI at once and the capture support is also incomplete. I don't see much problem merging the driver with these limitations, it's generally been much easier to get people to fix problems with merged drivers than to get people to contribute entirely new drivers. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
