On Sat, Jul 04, 2009 at 07:29:59PM -0700, Troy Kisky wrote:
> If the codec is master then prepare should call
> mcbsp_start, not trigger.
> Signed-off-by: Troy Kisky <troy.kisky@xxxxxxxxxxxxxxxxxxx>
This and 1-7 all look good, I've applied them. For this one (and some
of the others) it might've been nice to include a few more words about
the why.
> +static void davinci_i2s_shutdown(struct snd_pcm_substream *substream,
> + struct snd_soc_dai *dai)
> +{
> + struct snd_soc_pcm_runtime *rtd = substream->private_data;
> + struct davinci_mcbsp_dev *dev = rtd->dai->cpu_dai->private_data;
No need to bounce through rtd here or in prepare.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
