On Mon, May 25, 2009 at 6:26 AM, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: >> + spin_lock(&psc_dma->lock); >> + out_be32(&psc_dma->psc_regs->ac97_slots, psc_dma->slots); >> + spin_unlock(&psc_dma->lock); >> + break; > > This locking looks wrong - I'd expect it to also cover the modification > of psc_dma->slots? Otherwise it's hard to see what it buys you. Grant, why are you spin locking around register access? -- Jon Smirl jonsmirl@xxxxxxxxx _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
