Re: [RFC PATCH 4/5] ASoC: remove those unnecessary #ifdef CONFIG_PXA3xx .. #endif

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 23, 2009 at 01:06:55PM +0800, Eric Miao wrote:
> These are unnecessary since the compiler is smart enough to optimize
> the code away if CONFIG_PXA3xx is not defined, when cpu_is_pxa3xx()
> will just be expanded to constant 0.

This isn't done for compiler optimisation - it's done because the
register bit macros are only defined if PXA3xx support is being built
in.  I've no problem with removing those guards but without that you'll
get build failures on PXA2xx.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux