On Fri, Apr 17, 2009 at 6:22 PM, Mark Brown <broonie@xxxxxxxxxxxxx> wrote: > On Fri, Apr 17, 2009 at 11:39:38AM +0200, Philipp Zabel wrote: > >> To me, using ssp_dev seems to be cleaner, as all the places where >> ssp_set_scr is called, we already have an ssp_dev *ssp = priv->dev.ssp >> set up, which allows us to call ssp_set_scr(ssp, ...) instead of >> ssp_set_scr(&priv->dev, ...). Same for ssp_get_scr. > > Yeah, the combination of ssp_dev and ssp_device is icky in general and > largely historical as a result of a partially done transition of the > driver to ssp_device. > I'm working on that clean up. A lot of historical and dependency issues indeed. And the patch looks OK. The condition of cpu_is_pxa25x() might not be necessary though, ssp->type == PXA25x_SSP already implies that and is more specific. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
