Mark Brown wrote: > On Thu, Jan 15, 2009 at 10:16:10PM +0000, Ian Molton wrote: >> Mark Brown wrote: > >>>> + soc_ac97_ops.reset(codec->ac97); > >>> This should check the return value, resets can and do fail. > >> This call returns void. So no. > > Oh, sorry - thinko. You should read back the ID register and verify the > value. Implemented, tested, checkpatch passed. Pushed out and available at: git://git.mnementh.co.uk/linux-2.6-im.git asoc gitweb at: http://git.mnementh.co.uk/cgi-bin/gitweb.cgi?p=linux-2.6-im.git;a=shortlog;h=refs/heads/asoc Thanks for the review, -Ian _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
