On Thu, Jan 15, 2009 at 10:06:53AM +0000, Ian Molton wrote: > Takashi Iwai wrote: > > We need reviews. Could you post patches as well? > Sure - attached below: Always do this for ALSA patch submissions (the same thing will apply to the majority of kernel subsystems). Please also CC at least me on ASoC patches. I do read the list but it helps to make sure things don't get missed. These all look fine apart from one small thing in the codec driver and the issue Russell already pointed out. > + > + soc_ac97_ops.reset(codec->ac97); This should check the return value, resets can and do fail. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
