On Thu, Dec 4, 2008 at 8:47 PM, Daniel Mack <daniel@xxxxxxxxx> wrote: > Hi Mark, > > On Thu, Dec 04, 2008 at 06:37:47PM +0000, Mark Brown wrote: > > > Signed-off-by: Daniel Mack <daniel@xxxxxxxx> > > > Signed-off-by: Uli Luckas <u.luckas@xxxxxxx> > > Did you write this patch or did Uli? If you wrote it the line for Uli > > should be an Acked-by, if he wrote it then your Signed-off-by should > > come second and it should have a From: for him at the top. > > We're working on it together and share a git repository. I commited the > patch, sent it over to Uli to double-check it and he signed off on it > after I did it in the first place. > > I thought in such cases, two Signed-off-by: lines coming right after the > other is the way to go, but I can also change it to an 'Acked-by' if you > like. > > I'll wait for Jarkko's comments and repost. > > I just checked & tested a fix which changes those "xxx DAC Playback Switch" to "xxx Playback Switch" are correct. That would also allow to develop new "xxx Playback Volume" controls and gain 9 dB more of output level :-) Jarkko _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
