On Thu, Dec 04, 2008 at 06:51:21PM +0100, Daniel Mack wrote: > - split "Line Playback Switch" into "LineL Playback Switch" and "LineR > Playback Switch" > - split "Line PGA Bypass Playback Volume" into "LineL Left PGA Bypass > Playback Volume" and "LineR Right PGA Bypass Playback Volume" I can't help thinking that it'd be easier to just use "Left Line" and "Right Line" but that's an existing issue in the driver. > Signed-off-by: Daniel Mack <daniel@xxxxxxxx> > Signed-off-by: Uli Luckas <u.luckas@xxxxxxx> Did you write this patch or did Uli? If you wrote it the line for Uli should be an Acked-by, if he wrote it then your Signed-off-by should come second and it should have a From: for him at the top. The patch itself looks good. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel