On Thu, Dec 4, 2008 at 8:37 PM, Mark Brown <broonie@xxxxxxxxxxxxx> wrote:
> On Thu, Dec 04, 2008 at 06:51:21PM +0100, Daniel Mack wrote:
>
> > - split "Line Playback Switch" into "LineL Playback Switch" and "LineR
> > Playback Switch"
> > - split "Line PGA Bypass Playback Volume" into "LineL Left PGA Bypass
> > Playback Volume" and "LineR Right PGA Bypass Playback Volume"
>
> I can't help thinking that it'd be easier to just use "Left Line" and
> "Right Line" but that's an existing issue in the driver.
>
Yeah, same thoughts. Started to look only now, but what's the idea to
separate stereo control into two mono control in commit
54f01916297bafc18bd7df4e2300a0544a84fce3? Change like
- SOC_DOUBLE_R("HP PGA Bypass Playback Volume", PGAL_2_HPLOUT_VOL,
- PGAR_2_HPROUT_VOL, 0, 0x7f, 1),
+ SOC_SINGLE("HPL PGA Bypass Playback Volume", PGAL_2_HPLOUT_VOL,
+ 0, 0x7f, 1),
+ SOC_SINGLE("HPR PGA Bypass Playback Volume", PGAL_2_HPROUT_VOL,
+ 0, 0x7f, 1),
Jarkko
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
