On Fri, Dec 5, 2008 at 9:48 AM, Jarkko Nikula <jhnikula@xxxxxxxxx> wrote: > 2008/12/4 Grazvydas Ignotas <notasas@xxxxxxxxx> >> >> + /* Set McBSP clock to external */ >> + ret = snd_soc_dai_set_sysclk(cpu_dai, OMAP_MCBSP_SYSCLK_CLKS_EXT, >> 0, >> + SND_SOC_CLOCK_IN); > > I'm glad to see external clocking using with McBSP. Never tested feature :-) Yup, and in works fine. Thanks for adding support for that!. > >> +/* Digital audio interface glue - connects codec <--> CPU */ >> +static struct snd_soc_dai_link omap3pandora_dai[] = { >> + { >> + .name = "PCM1773", >> + .stream_name = "HiFi Out", >> + .cpu_dai = &omap_mcbsp_dai[0], >> + .codec_dai = &twl4030_dai, >> + .ops = &omap3pandora_out_ops, >> + .init = omap3pandora_out_init, >> + }, { >> + .name = "TWL4030", >> + .stream_name = "Line/Mic In", >> + .cpu_dai = &omap_mcbsp_dai[1], >> + .codec_dai = &twl4030_dai, >> + .ops = &omap3pandora_in_ops, >> + .init = omap3pandora_in_init, >> + } >> +}; > > Nice, first OMAP machine driver using McBSP in multilink configuration. We also have bluetooth path, but I've left that for another time. >> + if (!machine_is_omap3_pandora()) { >> + pr_debug(PREFIX "Not OMAP3 Pandora\n"); >> + return -ENODEV; >> + } >> + pr_info("OMAP3 Pandora SoC init\n"); >> + > > Minor muttering, but I don't see very much use for these debug prints. Well, every other OMAP3 board file has this. Do I need to resend? _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel