2008/12/4 Grazvydas Ignotas <notasas@xxxxxxxxx>
> This patch adds basic support for OMAP3 Pandora.
>
> Signed-off-by: Grazvydas Ignotas <notasas@xxxxxxxxx>
> ---
> sound/soc/omap/Kconfig | 8 +
> sound/soc/omap/Makefile | 2 +
> sound/soc/omap/omap3pandora.c | 311
> +++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 321 insertions(+), 0 deletions(-)
> create mode 100644 sound/soc/omap/omap3pandora.c
Hi
I like this board file! It definetely deserves a place in sound/soc/omap.
> + /* Set McBSP clock to external */
> + ret = snd_soc_dai_set_sysclk(cpu_dai, OMAP_MCBSP_SYSCLK_CLKS_EXT,
> 0,
> + SND_SOC_CLOCK_IN);
I'm glad to see external clocking using with McBSP. Never tested feature :-)
+/* Digital audio interface glue - connects codec <--> CPU */
> +static struct snd_soc_dai_link omap3pandora_dai[] = {
> + {
> + .name = "PCM1773",
> + .stream_name = "HiFi Out",
> + .cpu_dai = &omap_mcbsp_dai[0],
> + .codec_dai = &twl4030_dai,
> + .ops = &omap3pandora_out_ops,
> + .init = omap3pandora_out_init,
> + }, {
> + .name = "TWL4030",
> + .stream_name = "Line/Mic In",
> + .cpu_dai = &omap_mcbsp_dai[1],
> + .codec_dai = &twl4030_dai,
> + .ops = &omap3pandora_in_ops,
> + .init = omap3pandora_in_init,
> + }
> +};
Nice, first OMAP machine driver using McBSP in multilink configuration.
> + if (!machine_is_omap3_pandora()) {
> + pr_debug(PREFIX "Not OMAP3 Pandora\n");
> + return -ENODEV;
> + }
> + pr_info("OMAP3 Pandora SoC init\n");
> +
Minor muttering, but I don't see very much use for these debug prints.
Jarkko
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
