On 09/09/2024 18:23, Greg KH wrote: >>>>> Soundwire core and existing codecs expect that the array passed as >>>>> prop.sink_ports and prop.source_ports is continuous. The port mask still >>>>> might be non-continuous, but that's unrelated. >>>>> >>>>> Reported-by: Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx> >>>>> Closes: https://lore.kernel.org/all/b6c75eee-761d-44c8-8413-2a5b34ee2f98@xxxxxxxxxxxxxxx/ >>>>> Fixes: ab8d66d132bc ("soundwire: stream: fix programming slave ports for non-continous port maps") >>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >>>>> >>>>> --- >>>> >>>> Would be good to merge this as soon as we can, this is causing >>>> soundwire regressions from rc6 onwards. >>> >>> the revert also needs to happen in -stable. 6.10.8 is broken as well. >> >> It will happen. You do not need to Cc-stable (and it will not help, will >> not be picked), because this is marked as fix for existing commit. > > No, "Fixes:" tags only do not guarantee anything going to stable, you > have to explicitly tag it Cc: stable to do so, as per the documentation. Then anyway cc-stable not in body won't work. > > Yes, we often pick up "Fixes:" only tags, when we have the time, but > again, never guaranteed at all. Hm, I assumed you are still taking fixes for the fixes automatically. That's the case here. I will resend with cc-stable in such case. Best regards, Krzysztof
