On Mon, Sep 09, 2024 at 06:08:14PM +0200, Krzysztof Kozlowski wrote: > On 09/09/2024 17:45, Pierre-Louis Bossart wrote: > > > > > > On 9/9/24 16:36, Charles Keepax wrote: > >> On Wed, Sep 04, 2024 at 04:52:28PM +0200, Krzysztof Kozlowski wrote: > >>> This reverts commit ab8d66d132bc8f1992d3eb6cab8d32dda6733c84 because it > >>> breaks codecs using non-continuous masks in source and sink ports. The > >>> commit missed the point that port numbers are not used as indices for > >>> iterating over prop.sink_ports or prop.source_ports. > >>> > >>> Soundwire core and existing codecs expect that the array passed as > >>> prop.sink_ports and prop.source_ports is continuous. The port mask still > >>> might be non-continuous, but that's unrelated. > >>> > >>> Reported-by: Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx> > >>> Closes: https://lore.kernel.org/all/b6c75eee-761d-44c8-8413-2a5b34ee2f98@xxxxxxxxxxxxxxx/ > >>> Fixes: ab8d66d132bc ("soundwire: stream: fix programming slave ports for non-continous port maps") > >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > >>> > >>> --- > >> > >> Would be good to merge this as soon as we can, this is causing > >> soundwire regressions from rc6 onwards. > > > > the revert also needs to happen in -stable. 6.10.8 is broken as well. > > It will happen. You do not need to Cc-stable (and it will not help, will > not be picked), because this is marked as fix for existing commit. No, "Fixes:" tags only do not guarantee anything going to stable, you have to explicitly tag it Cc: stable to do so, as per the documentation. Yes, we often pick up "Fixes:" only tags, when we have the time, but again, never guaranteed at all. thanks, greg k-h
