Hi Broonie Thank for your feedback. I will resend them. One more thing, these day my colleague and I want have some adjustment on the tas2781 driver code to support both i2c and spi interface, and plan to abstract the common part, especially the dsp binary parsing, as a shared lib. Would you be so kind and give us some advice on it? Thanks. > -----Original Message----- > From: Mark Brown <broonie@xxxxxxxxxx> > Sent: Tuesday, July 30, 2024 12:42 AM > To: Ding, Shenghao <shenghao-ding@xxxxxx> > Cc: andriy.shevchenko@xxxxxxxxxxxxxxx; lgirdwood@xxxxxxxxx; > perex@xxxxxxxx; pierre-louis.bossart@xxxxxxxxxxxxxxx; > 13916275206@xxxxxxx; zhourui@xxxxxxxxxx; alsa-devel@xxxxxxxxxxxxxxxx; > Salazar, Ivan <i-salazar@xxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; Chadha, Jasjot > Singh <j-chadha@xxxxxx>; liam.r.girdwood@xxxxxxxxx; Yue, Jaden <jaden- > yue@xxxxxx>; yung-chuan.liao@xxxxxxxxxxxxxxx; Rao, Dipa <dipa@xxxxxx>; > yuhsuan@xxxxxxxxxx; Lo, Henry <henry.lo@xxxxxx>; tiwai@xxxxxxx; Xu, > Baojun <baojun.xu@xxxxxx>; soyer@xxxxxx; Baojun.Xu@xxxxxxx; > judyhsiao@xxxxxxxxxx; Navada Kanyana, Mukund <navada@xxxxxx>; > cujomalainey@xxxxxxxxxx; Kutty, Aanya <aanya@xxxxxx>; Mahmud, Nayeem > <nayeem.mahmud@xxxxxx>; savyasanchi.shukla@xxxxxxxxxxxxx; > flaviopr@xxxxxxxxxxxxx; Ji, Jesse <jesse-ji@xxxxxx>; darren.ye@xxxxxxxxxxxx; > antheas.dk@xxxxxxxxx > Subject: [EXTERNAL] Re: [PATCH v1] ASoc: tas2781: Move tas2563_dvc_table > into a separate Header file > > On Tue, Jul 16, 2024 at 02:11:21PM +0800, Shenghao Ding wrote: > > Move tas2563_dvc_table into a separate Header file, as only tas2781 > > codec driver use this table, and hda side codec driver won't use it. > > This doesn't apply against current code (or your other patch to this driver from > the same day), please check and resend?
