Re: [PATCH 0/3] slimbus: use 'time_left' instead of 'timeout' with wait_for_*() functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 30, 2024 at 06:30:00AM -0700, Bjorn Andersson wrote:
> On Tue, Apr 30, 2024 at 02:00:58PM +0200, Wolfram Sang wrote:
> > There is a confusing pattern in the kernel to use a variable named 'timeout' to
> > store the result of wait_for_*() functions causing patterns like:
> > 
> >         timeout = wait_for_completion_timeout(...)
> >         if (!timeout) return -ETIMEDOUT;
> > 
> > with all kinds of permutations. Use 'time_left' as a variable to make the code
> > obvious and self explaining.
> > 
> > This is part of a tree-wide series. The rest of the patches can be found here
> > (some parts may still be WIP):
> > 
> > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/time_left
> > 
> > Because these patches are generated, I audit them before sending. This is why I
> > will send series step by step. Build bot is happy with these patches, though.
> > No functional changes intended.
> > 
> 
> Reviewed-by: Bjorn Andersson <quic_bjorande@xxxxxxxxxxx>

Thanks, Bjorn. Is Srinivas still pick slimbus patches?

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux