From: "Mark Brown" <broonie@xxxxxxxxxx> Sent: Friday, 31 May, 2024 15:14:13 > On Fri, May 31, 2024 at 08:48:04AM -0400, Elinor Montmasson wrote: > >> Then maybe it's not be a good idea to make this compatible generic >> for this contribution. >> The original intention is to bring support for the S/PDIF, >> so maybe the contribution should focus on this use case? >> In that case, would changing the compatible for "fsl,imx-audio-spdif-card" >> be acceptable? >> "fsl,imx-audio-spdif" is already used for the `imx-spdif.c` >> which does not use the ASRC. > > Why not just use the existing compatible - why would someone not want to > be able to use the ASRC if it's available in their system? That's true but it will be a problem if both `fsl-asoc-card.c` and `imx-spdif.c` drivers have the same compatible, and they don't have the same DT properties.