> -----Original Message----- > From: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> > Sent: Monday, May 27, 2024 9:44 PM > To: Ding, Shenghao <shenghao-ding@xxxxxx>; broonie@xxxxxxxxxx > Cc: andriy.shevchenko@xxxxxxxxxxxxxxx; lgirdwood@xxxxxxxxx; > perex@xxxxxxxx; 13916275206@xxxxxxx; alsa-devel@xxxxxxxxxxxxxxxx; > Salazar, Ivan <i-salazar@xxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; Chadha, > Jasjot Singh <j-chadha@xxxxxx>; liam.r.girdwood@xxxxxxxxx; Yue, Jaden > <jaden-yue@xxxxxx>; yung-chuan.liao@xxxxxxxxxxxxxxx; Rao, Dipa > <dipa@xxxxxx>; Lu, Kevin <kevin-lu@xxxxxx>; yuhsuan@xxxxxxxxxx; > tiwai@xxxxxxx; Xu, Baojun <baojun.xu@xxxxxx>; soyer@xxxxxx; > Baojun.Xu@xxxxxxx; judyhsiao@xxxxxxxxxx; Navada Kanyana, Mukund > <navada@xxxxxx>; cujomalainey@xxxxxxxxxx; Kutty, Aanya > <aanya@xxxxxx>; Mahmud, Nayeem <nayeem.mahmud@xxxxxx> > Subject: [EXTERNAL] Re: [PATCH v2] ASoc: tas2781: Playback can work when > only RCA binary loading without dsp firmware loading > > On 5/24/24 20: 47, Shenghao Ding wrote: > In only RCA binary loading case, > only default dsp program inside the > chip will be work. What does 'RCA' > stand for? Also clarify the commit title without double negatives, e. g. "Enable > RCA-based ZjQcmQRYFpfptBannerStart This message was sent from outside > of Texas Instruments. > Do not click links or open attachments unless you recognize the source of this > email and know the content is safe. If you wish to report this message to IT > Security, please forward the message as an attachment to > phishing@xxxxxxxxxxx > > ZjQcmQRYFpfptBannerEnd > > > On 5/24/24 20:47, Shenghao Ding wrote: > > In only RCA binary loading case, only default dsp program inside the > > chip will be work. > ...................................................................... > > - if (tas_priv->fw_state == TASDEVICE_DSP_FW_FAIL) { > > - /*If DSP FW fail, kcontrol won't be created */ > > - tasdevice_config_info_remove(tas_priv); > > + if (tas_priv->fw_state == TASDEVICE_RCA_FW_OK) { > > + /*If DSP FW fail, DSP kcontrol won't be created */ > > It looks like you're no longer using PENDING and FAIL states? > The state machine is becoming really hard to follow. PENDING and FAIL states have been used in HDA-based tas2563/tas2781 driver > > > tasdevice_dsp_remove(tas_priv); > > } > > mutex_unlock(&tas_priv->codec_lock); > > @@ -466,14 +472,14 @@ static int tasdevice_startup(struct > > snd_pcm_substream *substream, { > > struct snd_soc_component *codec = dai->component; > > struct tasdevice_priv *tas_priv = ..................................................................................