On 5/20/24 09:05, Shuming [范書銘] wrote: >>> +static const struct sdw_device_id rt1320_id[] = { >>> + SDW_SLAVE_ENTRY_EXT(0x025d, 0x1320, 0x3, 0x0, 0), >>> + SDW_SLAVE_ENTRY_EXT(0x025d, 0x1320, 0x3, 0x1, 0), >>> + {}, >> >> Sorry, not following why one of the two entries in the table is an SDCA class >> device and the other not - both rely on SDCA controls/entities/functions/etc. >> That doesn't really align with the notion that VA and VB only differ by their DSP >> capabilities, so not sure what the 0/1 difference means. > > VA/VB will use class id 0 because of the hardware issue. > VC will fix this and use the class id 1. ok, a comment would help.