On Mon, May 06, 2024 at 07:44:05AM +0000, Xu, Baojun wrote: > > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > Sent: 02 May 2024 18:22 > > To: Xu, Baojun > > On Thu, Apr 25, 2024 at 07: 54: 41AM +0000, Xu, Baojun wrote: > > On Thu, Apr 25, 2024 at 07:54:41AM +0000, Xu, Baojun wrote: > > > > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > > > Sent: 18 April 2024 19:56 > > > > On Thu, Apr 18, 2024 at 12: 02: 37PM +0800, Baojun Xu wrote: > > > > On Thu, Apr 18, 2024 at 12:02:37PM +0800, Baojun Xu wrote: ... > > > > > sound/pci/hda/Kconfig | 15 +++++++++++++++ > > > > > sound/pci/hda/Makefile | 2 ++ > > > > > > > Is this correct? You are adding a dead "code", isn't it? > > > > > > What's mean "dead code"? After add CONFIG_SND_HDA_SCODEC_TAS2781_SPI=m > > > in my config file, the whole patch code has worked. > > > > Is that file already in the repository? > > If not, I don't see it in this patch either --> dead code. > > When I integrated CONFIG_SND_HDA_SCODEC_TAS2781_SPI and compiled the whole kernel, > it used to popup the following message for TAS2781 SPI module in first compile: > > Build TAS2781 HD-audio side codec support for SPI Bus (SND_HDA_SCODEC_TAS2781_SPI) [N/m/?] (NEW) > > Normally, selected m. And TAS2781 SPI module would be compiled. The above is a dead code if this SPI driver is not yet in the kernel. Is it? What is the path to it in the current kernel source tree? -- With Best Regards, Andy Shevchenko