On Thu, Apr 18, 2024 at 12:02:37PM +0800, Baojun Xu wrote: > Integrate tas2781 configs for HP Laptops. Every tas2781 in the laptop > will work as a single speaker on SPI bus. The code support realtek as Realtek > the primary codec. ... > sound/pci/hda/Kconfig | 15 +++++++++++++++ > sound/pci/hda/Makefile | 2 ++ Is this correct? You are adding a dead "code", isn't it? ... The rest LGTM. -- With Best Regards, Andy Shevchenko