On Thu, Apr 18, 2024 at 05:12:03AM +0000, Xu, Baojun wrote: > > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > Sent: 09 April 2024 21:21 > > To: Xu, Baojun > > On Tue, Apr 09, 2024 at 10: 48: 14AM +0800, Baojun Xu wrote: > > On Tue, Apr 09, 2024 at 10:48:14AM +0800, Baojun Xu wrote: ... > > > +#ifndef __TAS2781_SPI_H__ > > > +#define __TAS2781_SPI_H__ > > > > + bits.h > > + mutex.h > > + time.h? (for struct tm) > > + types.h > > > > struct calidata is from?.. > > > > > +#include <sound/tas2781-dsp.h> > > > > Not sure how this is being used. > > Was used for firmware binary file parser, all of file format information > was defined in this header file. It can be shared between SPI & I2C. _This header_ file seems not using anything from it, does it? > > Also some forward declarations: > > > > + struct device; > > + struct firmware; > > + struct gpio_desc; > > + struct regmap; -- With Best Regards, Andy Shevchenko
