On Thu, May 02, 2024 at 11:25:13AM +0200, Uwe Kleine-König wrote: > Hello Andy, > > On Thu, May 02, 2024 at 12:02:50PM +0300, Andy Shevchenko wrote: > > On Thu, May 2, 2024 at 10:47 AM Uwe Kleine-König > > <u.kleine-koenig@xxxxxxxxxxxxxx> wrote: > > > > > > These drivers don't use the driver_data member of struct i2c_device_id, > > > so don't explicitly initialize this member. > > > > > > This prepares putting driver_data in an anonymous union which requires > > > either no initialization or named designators. But it's also a nice > > > cleanup on its own. > > > > There are some drivers that have other (than I²C) ID tables, which > > follow the same format. Can you also do the same with them for the > > sake of consistency? > > I'm aware of these and plan to address them in a separate quest once I'm > done with the i2c bits. With this being promised, FWIW, Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> -- With Best Regards, Andy Shevchenko